[php-blog-tracker] [ php-blog-Bugs-2845527 ] Spartacus broken by SF ViewVC update/changes?

[SourceForge.net]

Bugs item #2845527, was opened at 2009-08-27 14:25
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=2845527&group_id=75065

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Christian Boltz (christian_boltz)
Assigned to: Nobody/Anonymous (nobody)
Summary: Spartacus broken by SF ViewVC update/changes?

Initial Comment:
It looks like spartacus was broken by a VievVC update on sourceforge.

I use S9Y 1.4 (svn branch) and tried to update some plugins with spartacus. The result were lots of error messages saying the server returned a 400 error.

The solution is to replace ?rev= with ?revision=

The most important change is in the patch below. However, ?rev= appears more than once in the file - you'll probably need to replace it everywhere.

--- serendipity_event_spartacus.php (Revision 2578)
+++ serendipity_event_spartacus.php (Arbeitskopie)
@@ -954,7 +954,7 @@
}

foreach($files AS $file) {
- $url = $mirror . '/' . $sfloc . '/' . $file . '?rev=1.9999';
+ $url = $mirror . '/' . $sfloc . '/' . $file . '?revision=1.9999';
$target = $pdir . $file;
$this->rmkdir($pdir . $plugin_to_install,$sub);
$this->fileperm($pdir . $plugin_to_install, true);

Sidenote: I have no idea about the ViewVC version on mirrors and if they will accept the ?revision= parameter. However things can't go worse then what happened to me (spartacus completely useless because it can't download the files).

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)

Date: 2011-04-24 18:49

Message:
Just going through my open bugreports...

Garvin, your last comment says you commited the fix - is there a special
reason why this bugreport is still open?

----------------------------------------------------------------------

Comment By: Garvin Hicking (garvinhicking)
Date: 2009-08-27 15:33

Message:
That's really strange, I wonder why the redirect fails. Maybe due to a HTTP
header sniffer.

Anyhow, I've committed your patch, thanks a lot! :)



----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2009-08-27 15:26

Message:
yes, exactly.
(Looking at it a again, there's also a /viewvc/ before /*checkout*/
missing - but interestingly this didn't cause any problem.)

Hmm, could it be that my PHP version (php5-5.2.9 on openSUSE 11.1) has
different defaults for php5-curl than yours?
http://www.php.net/manual/en/function.curl-setopt.php lists settings like
CURLOPT_FOLLOWLOCATION and CURLOPT_MAXREDIRS.

----------------------------------------------------------------------

Comment By: Garvin Hicking (garvinhicking)
Date: 2009-08-27 15:10

Message:
Hi!

Thanks for reporting...but this is strange, when I call this URL I get a
HTTP redirect; and this should be supported by the Spartacus library.

With that patch it works for you?

Regards,
Garvin

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=2845527&group_id=75065