[php-blog-tracker] [ php-blog-Bugs-3307105 ] COMMENT_DELETED displayed after deleting comment

[SourceForge.net]

Bugs item #3307105, was opened at 2011-05-24 21:56
Message generated for change (Tracker Item Submitted) made by christian_boltz
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=3307105&group_id=75065

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Administrative functions
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Christian Boltz (christian_boltz)
Assigned to: Nobody/Anonymous (nobody)
Summary: COMMENT_DELETED displayed after deleting comment

Initial Comment:
I'm using S9Y from the 1.5 SVN branch, r2717 (which basically means 1.5.5).

I deleted a (auto-approved) comment with the "delete comment" link in the comment notification mail ($domain/delete/comment_token_......)

The result was somewhat unexpected - my blog displayed a comment like

$author zu $article $date
COMMENT_DELETED

in the sidebar instead of hiding the comment.

I can also see the comment with the "COMMENT_DELETED" text in the backend - for now, I have set it to "moderation" to hide it from the frontend.

This seems to affect only published comments. Deleting comments that wait for moderation works as expected.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=3307105&group_id=75065

[SourceForge.net]

Bugs item #3307105, was opened at 2011-05-24 19:56
Message generated for change (Comment added) made by garvinhicking
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=3307105&group_id=75065

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Administrative functions
Group: None

Status: Pending

Resolution: None

Priority: 3

Private: No
Submitted By: Christian Boltz (christian_boltz)

Assigned to: Garvin Hicking (garvinhicking)

Summary: COMMENT_DELETED displayed after deleting comment

Initial Comment:
I'm using S9Y from the 1.5 SVN branch, r2717 (which basically means 1.5.5).

I deleted a (auto-approved) comment with the "delete comment" link in the comment notification mail ($domain/delete/comment_token_......)

The result was somewhat unexpected - my blog displayed a comment like

$author zu $article $date
COMMENT_DELETED

in the sidebar instead of hiding the comment.

I can also see the comment with the "COMMENT_DELETED" text in the backend - for now, I have set it to "moderation" to hide it from the frontend.

This seems to affect only published comments. Deleting comments that wait for moderation works as expected.

----------------------------------------------------------------------

Comment By: Garvin Hicking (garvinhicking)

Date: 2011-05-24 20:19

Message:
Hi!

Actually, this should be expected behaviour - the comment body gets
replaced with the constant "COMMENT_DELETED" if there is a reply to the
comment you are deleting. If the comment were deleted, then the response
would also all be deleted, whichi s why we chose this "deleted" method.

Can this be the cause, or are you sure the comment you wanted to delete
has no associated replies?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=3307105&group_id=75065

[SourceForge.net]

Bugs item #3307105, was opened at 2011-05-24 21:56
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=3307105&group_id=75065

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Administrative functions
Group: None

Post by SourceForge.net
Status: Open

Resolution: None
Priority: 3
Private: No
Submitted By: Christian Boltz (christian_boltz)
Assigned to: Garvin Hicking (garvinhicking)
Summary: COMMENT_DELETED displayed after deleting comment

Initial Comment:
I'm using S9Y from the 1.5 SVN branch, r2717 (which basically means 1.5.5).

I deleted a (auto-approved) comment with the "delete comment" link in the comment notification mail ($domain/delete/comment_token_......)

The result was somewhat unexpected - my blog displayed a comment like

$author zu $article $date
COMMENT_DELETED

in the sidebar instead of hiding the comment.

I can also see the comment with the "COMMENT_DELETED" text in the backend - for now, I have set it to "moderation" to hide it from the frontend.

This seems to affect only published comments. Deleting comments that wait for moderation works as expected.

----------------------------------------------------------------------

Post by SourceForge.net
Comment By: Christian Boltz (christian_boltz)

Date: 2011-05-25 01:25

Message:
Good question. I got a series of spam comments today (but that's another
story, even if it's quite unusual), and the mentioned comment was one of
it.

How can I check if other comments are replies to this comment? (I have no
problem with digging into the database if necessary ;-)
(... 5 minutes later ...)
Hmm, just looked at the database, and it really looks like another comment
refers to it: (the comment with COMMENT_DELETED is #175)

select * from serendipity_comments where parent_id > 0 and entry_id = 59
\G
*************************** 1. row ***************************
id: 182
entry_id: 59
parent_id: 175
[...]
type: NORMAL
subscribed: false
status: pending
referer: [...]

However it is in status "pending", which means there isn't a good reason
to display the "deleted" comment ;-) - there's no _visible_ child that
would require it.

Oh, BTW: If I click on the "edit" link for comment #182, "Ursprung" is
selected in the "reply to" dropdown. That's different from what the
database has.

----------------------------------------------------------------------

Comment By: Garvin Hicking (garvinhicking)
Date: 2011-05-24 22:19

Message:
Hi!

Actually, this should be expected behaviour - the comment body gets
replaced with the constant "COMMENT_DELETED" if there is a reply to the
comment you are deleting. If the comment were deleted, then the response
would also all be deleted, whichi s why we chose this "deleted" method.

Can this be the cause, or are you sure the comment you wanted to delete
has no associated replies?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=3307105&group_id=75065

[SourceForge.net]

Bugs item #3307105, was opened at 2011-05-24 19:56
Message generated for change (Comment added) made by garvinhicking
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=3307105&group_id=75065

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Administrative functions
Group: None
Status: Open
Resolution: None
Priority: 3
Private: No
Submitted By: Christian Boltz (christian_boltz)
Assigned to: Garvin Hicking (garvinhicking)
Summary: COMMENT_DELETED displayed after deleting comment

Initial Comment:
I'm using S9Y from the 1.5 SVN branch, r2717 (which basically means 1.5.5).

I deleted a (auto-approved) comment with the "delete comment" link in the comment notification mail ($domain/delete/comment_token_......)

The result was somewhat unexpected - my blog displayed a comment like

$author zu $article $date
COMMENT_DELETED

in the sidebar instead of hiding the comment.

I can also see the comment with the "COMMENT_DELETED" text in the backend - for now, I have set it to "moderation" to hide it from the frontend.

This seems to affect only published comments. Deleting comments that wait for moderation works as expected.

----------------------------------------------------------------------

Comment By: Garvin Hicking (garvinhicking)
Date: 2011-05-25 07:12

Message:
Hi!

Good to know that this is the cause.

About the 'pending' / visibility state: On the one hand you are right, on
the other, if such a pending comment were approved, it would not properly
link to the original comment.

What s9y actually should do is that you delete such a "COMMENTDELETED"
comment again, it should effectively be removed, have you tried that?

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-05-24 23:25

Message:
Good question. I got a series of spam comments today (but that's another
story, even if it's quite unusual), and the mentioned comment was one of
it.

How can I check if other comments are replies to this comment? (I have no
problem with digging into the database if necessary ;-)
(... 5 minutes later ...)
Hmm, just looked at the database, and it really looks like another comment
refers to it: (the comment with COMMENT_DELETED is #175)

select * from serendipity_comments where parent_id > 0 and entry_id = 59
\G
*************************** 1. row ***************************
id: 182
entry_id: 59
parent_id: 175
[...]
type: NORMAL
subscribed: false
status: pending
referer: [...]

However it is in status "pending", which means there isn't a good reason
to display the "deleted" comment ;-) - there's no _visible_ child that
would require it.

Oh, BTW: If I click on the "edit" link for comment #182, "Ursprung" is
selected in the "reply to" dropdown. That's different from what the
database has.

----------------------------------------------------------------------

Comment By: Garvin Hicking (garvinhicking)
Date: 2011-05-24 20:19

Message:
Hi!

Actually, this should be expected behaviour - the comment body gets
replaced with the constant "COMMENT_DELETED" if there is a reply to the
comment you are deleting. If the comment were deleted, then the response
would also all be deleted, whichi s why we chose this "deleted" method.

Can this be the cause, or are you sure the comment you wanted to delete
has no associated replies?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=3307105&group_id=75065

[SourceForge.net]

Bugs item #3307105, was opened at 2011-05-24 21:56
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=3307105&group_id=75065

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Administrative functions
Group: None
Status: Open
Resolution: None
Priority: 3
Private: No
Submitted By: Christian Boltz (christian_boltz)
Assigned to: Garvin Hicking (garvinhicking)
Summary: COMMENT_DELETED displayed after deleting comment

Initial Comment:
I'm using S9Y from the 1.5 SVN branch, r2717 (which basically means 1.5.5).

I deleted a (auto-approved) comment with the "delete comment" link in the comment notification mail ($domain/delete/comment_token_......)

The result was somewhat unexpected - my blog displayed a comment like

$author zu $article $date
COMMENT_DELETED

in the sidebar instead of hiding the comment.

I can also see the comment with the "COMMENT_DELETED" text in the backend - for now, I have set it to "moderation" to hide it from the frontend.

This seems to affect only published comments. Deleting comments that wait for moderation works as expected.

----------------------------------------------------------------------

Post by SourceForge.net
Comment By: Christian Boltz (christian_boltz)

Date: 2011-06-05 21:06

Post by SourceForge.net
About the 'pending' / visibility state: On the one hand you are right,

on

Post by SourceForge.net
the other, if such a pending comment were approved, it would not

properly

Post by SourceForge.net
link to the original comment.

I'd like to propose two things:

a) add an additional note to the status text if I click the delete link in
the notification mail:
"One or more comments refer to this comment. The text has been removed,
but a COMMENT_DELETED note will stay visible. If you don't want this,
delete the comment again to remove it completely."
That shouldn't be too hard to implement ;-)

b) hide COMMENT_DELETED comments as long as the child comments are hidden

Post by SourceForge.net
What s9y actually should do is that you delete such a "COMMENTDELETED"
comment again, it should effectively be removed, have you tried that?

Just tested it - works :-) (I didn't check what happens to child comments
- which were also spam)

----------------------------------------------------------------------

Comment By: Garvin Hicking (garvinhicking)
Date: 2011-05-25 09:12

Message:
Hi!

Good to know that this is the cause.

About the 'pending' / visibility state: On the one hand you are right, on
the other, if such a pending comment were approved, it would not properly
link to the original comment.

What s9y actually should do is that you delete such a "COMMENTDELETED"
comment again, it should effectively be removed, have you tried that?

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2011-05-25 01:25

Message:
Good question. I got a series of spam comments today (but that's another
story, even if it's quite unusual), and the mentioned comment was one of
it.

How can I check if other comments are replies to this comment? (I have no
problem with digging into the database if necessary ;-)
(... 5 minutes later ...)
Hmm, just looked at the database, and it really looks like another comment
refers to it: (the comment with COMMENT_DELETED is #175)

select * from serendipity_comments where parent_id > 0 and entry_id = 59
\G
*************************** 1. row ***************************
id: 182
entry_id: 59
parent_id: 175
[...]
type: NORMAL
subscribed: false
status: pending
referer: [...]

However it is in status "pending", which means there isn't a good reason
to display the "deleted" comment ;-) - there's no _visible_ child that
would require it.

Oh, BTW: If I click on the "edit" link for comment #182, "Ursprung" is
selected in the "reply to" dropdown. That's different from what the
database has.

----------------------------------------------------------------------

Comment By: Garvin Hicking (garvinhicking)
Date: 2011-05-24 22:19

Message:
Hi!

Actually, this should be expected behaviour - the comment body gets
replaced with the constant "COMMENT_DELETED" if there is a reply to the
comment you are deleting. If the comment were deleted, then the response
would also all be deleted, whichi s why we chose this "deleted" method.

Can this be the cause, or are you sure the comment you wanted to delete
has no associated replies?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=542822&aid=3307105&group_id=75065